Skip to content

Proposal: get rid of notes like "note: In member "blah" of class "Blah":" #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Jul 7, 2016 · 2 comments · Fixed by #1922
Closed

Proposal: get rid of notes like "note: In member "blah" of class "Blah":" #1821

gvanrossum opened this issue Jul 7, 2016 · 2 comments · Fixed by #1922

Comments

@gvanrossum
Copy link
Member

When there's an error on a line it's pretty clear what function that is in, and the note clarifying that is not very useful. Let's get rid of such notes.

This would also make the unit tests a bit simpler -- we could use the # E: ... idiom more often.

@JukkaL
Copy link
Collaborator

JukkaL commented Jul 8, 2016

This is at least worth experimenting with. The output from mypy is a little noisy. Having In class "X": may still be useful in the output, as classes can span multiple screenfuls.

@gvanrossum gvanrossum added this to the 0.5 milestone Jul 14, 2016
@gvanrossum
Copy link
Member Author

This is the block labeled # Report context within a source file. in render_messages() in errors.py. Possibly all you need to do is take it out, and then patch up the unit tests that expect the message (of which there may be hundreds...).

ddfisher pushed a commit that referenced this issue Jul 22, 2016
gvanrossum added a commit that referenced this issue Jul 23, 2016
gvanrossum added a commit that referenced this issue Jul 25, 2016
gvanrossum added a commit that referenced this issue Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants