Skip to content

Add -q/--quieter flag to suppress notes about class/function #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Conversation

gvanrossum
Copy link
Member

Fixes #1821 (well enough for me to close it).

@gvanrossum
Copy link
Member Author

gvanrossum commented Jul 22, 2016

I made this an option so that we can experiment with it.

My main reason for wanting it now is that I have a rather large test with a bunch of errors aimed at specific lines, and I really want to use the # E: ... notation. The test (by its nature) contains several functions, so there would be several "In function ..." notes interspersed with the interesting errors (and the # E notation doesn't support that). Using this diff I can add "quieter" to the # options: section of the test to suppress those notes, so using # E becomes possible.

By leaving the default unchanged I won't have to clean up the zillions of other tests expecting these notes.

@ddfisher
Copy link
Collaborator

I worry that this PR will lead to us never fixing the user-facing aspects of #1821. I'd much rather see us do that all in one fell swoop.

Don't we have a flag for automatically fixing up test files?

@ddfisher
Copy link
Collaborator

Aside from that, it would be nice for this to have a more specific name.

@ddfisher
Copy link
Collaborator

I missed that this PR added a user-facing flag. With that in mind, this seems like a reasonable first step.

@ddfisher ddfisher merged commit a3a25eb into master Jul 22, 2016
@ddfisher ddfisher deleted the quieter branch July 22, 2016 20:55
gvanrossum added a commit that referenced this pull request Jul 23, 2016
gvanrossum added a commit that referenced this pull request Jul 25, 2016
gvanrossum added a commit that referenced this pull request Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: get rid of notes like "note: In member "blah" of class "Blah":"
2 participants