Fix overload resolution on Tuples #1585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def f(x: int, y: Tuple[str, ...]) -> None: pass | ||
| @overload | ||
| def f(x: int, y: str) -> None: pass | ||
| f(1, ('2', '3')) |
There was a problem hiding this comment.
Also test calling with a Tuple[str, ...] arg and a Tuple[int, ...] argument.
There was a problem hiding this comment.
Oops, now it's actually added.
rwbarton
force-pushed
the
rwbarton-overload-tuple
branch
from
1ec67ba to
b162a4a
Compare
Fixes python#1578, since list's __setitem__ is overloaded.
rwbarton
force-pushed
the
rwbarton-overload-tuple
branch
from
b162a4a to
ab2a7b2
Compare
|
@rwbarton Feel free to land this PR at any time if tests pass after fixing rebase conflicts. Sorry for the delay! |
|
Hmm, I thought I commented somewhere about this PR being unneeded after #1596, but now I can't find that comment... |
|
Oh right, I remember now. # Fall back to a conservative equality check for the remaining kinds of type.
return 2 if is_same_type(erasetype.erase_type(actual), erasetype.erase_type(formal)) else 0With the change to I'll still merge the tests though since they are a bit different than the ones added in #1596. |
|
I added the tests in commit 838b4e0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1578, since list's setitem is overloaded.