Fix generic function overloading with tuple types #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1595. There were actually two issues: * Erasing tuple types was incorrect, as the fallback type was not erased. * Some tuple types got generated without a type argument, even though a uniform tuple type is internally represented as instance type tuple[t]. Similar issues might still arise in other contexts but at least this is improves things a little. Also, we generate fallback types that are like Tuple[Any, ...]. We could potentially generate a more precise fallback type, but that would potentially require joins and I'm not sure if we can use them during semantic analysis.
|
Thanks for the quick fix! There are a few issues left with python/typeshed#223 but way fewer than before (only one per repo) and of a different nature. |
|
I'm glad the bare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1595.
There were actually two issues:
a uniform tuple type is internally represented as instance type tuple[t].
Similar issues might still arise in other contexts but at least this is
improves things a little.
Also, we generate fallback types that are like Tuple[Any, ...]. We could
potentially generate a more precise fallback type, but that would potentially
require joins and I'm not sure if we can use them during semantic analysis.