Original node wins in case of a redefinition (especially if it is a class)#5565
Merged
Conversation
Member
|
I submitted python/typeshed#2424 to fix the bad stub. Probably better to get that fix in first so mypy can be more consistent. |
JukkaL
approved these changes
Sep 4, 2018
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one question about a test.
| name = node.name() | ||
| if name in self.locals[-1]: | ||
| self.name_already_defined(name, ctx, self.locals[-1][name]) | ||
| return |
Collaborator
There was a problem hiding this comment.
Is there a test case for this?
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5534
In principle we can be even more strict (see a little exception for class scope) but then we need to work on python/typeshed#2423 first.