Skip to content

Duplicate attributes in tornado stubs #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilevkivskyi opened this issue Sep 3, 2018 · 0 comments
Closed

Duplicate attributes in tornado stubs #2423

ilevkivskyi opened this issue Sep 3, 2018 · 0 comments

Comments

@ilevkivskyi
Copy link
Member

I am working on some unrelated things and noticed these errors:

mypy/typeshed/third_party/2/tornado/httpclient.pyi:58: error: Name 'headers' already defined on line 26
mypy/typeshed/third_party/2/tornado/httpclient.pyi:62: error: Name 'body' already defined on line 33
mypy/typeshed/third_party/2/tornado/httpclient.pyi:66: error: Name 'body_producer' already defined on line 34
mypy/typeshed/third_party/2/tornado/httpclient.pyi:70: error: Name 'streaming_callback' already defined on line 45
mypy/typeshed/third_party/2/tornado/httpclient.pyi:74: error: Name 'header_callback' already defined on line 46
mypy/typeshed/third_party/2/tornado/httpclient.pyi:78: error: Name 'prepare_curl_callback' already defined on line 47

This are technically OK, but anyway it looks like an inconsistency that should not be in typeshed IMO.
@ilevkivskyi ilevkivskyi mentioned this issue Sep 3, 2018
Merged
JelleZijlstra added a commit that referenced this issue Sep 3, 2018
@JelleZijlstra
fix duplicate definitions in tornado
5fc5aba 
Fixes #2423.

I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the `@property` where it exists in the implementation and the attribute where it doesn't.
@JelleZijlstra JelleZijlstra mentioned this issue Sep 3, 2018
Merged
JelleZijlstra added a commit that referenced this issue Sep 3, 2018
@JelleZijlstra
fix duplicate definitions in tornado (#2424)
2e1c816 
Fixes #2423.

I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the `@property` where it exists in the implementation and the attribute where it doesn't.
cocoatomo pushed a commit to cocoatomo/typeshed that referenced this issue Sep 8, 2018
@JelleZijlstra @cocoatomo
fix duplicate definitions in tornado (python#2424)
217550a 
Fixes python#2423.

I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the `@property` where it exists in the implementation and the attribute where it doesn't.
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this issue Jan 23, 2019
@JelleZijlstra
fix duplicate definitions in tornado (python#2424)
f2353bb 
Fixes python#2423.

I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the `@property` where it exists in the implementation and the attribute where it doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilevkivskyi