Skip to content

Translate library/symtable.po #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Conversation

mattwang44
Copy link
Collaborator

@mattwang44 mattwang44 commented Aug 10, 2023

Preview image

@mattwang44 mattwang44 force-pushed the library/symtable branch 2 times, most recently from 5d89aa0 to 3522be9 Compare August 10, 2023 17:41
@mattwang44
Copy link
Collaborator Author

@rockleona 這個 PR 想請你幫忙 review 🙏🏽


#: ../../library/symtable.rst:59
msgid "Return ``True`` if the locals in this table can be optimized."
msgstr ""
msgstr "如果可以最佳化該表中的局部變數,則回傳 ``True``。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locals == local variables ?
如果是的話是不是翻譯成區域變數比較好?

Suggested change
msgstr "如果可以最佳化該表中的局部變數,則回傳 ``True``。"
msgstr "如果可以最佳化該表中的區域變數,則回傳 ``True``。"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

樂詞網是 局部變數 那好吧XD
但我會覺得有點微妙,就是詞性對應的關係

e.g., Local Variable vs Global Variable;
區域變數 vs 全域變數 ;
局部變數 vs 全局變數

差不多是這樣的概念

Copy link
Collaborator Author

@mattwang44 mattwang44 Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 我先改成其中一組,然後開個 discussion
  • 不過你這麼一說我才發覺 locals != local variable,前者應該是專指 python 關鍵字 locals 所代表的東西,也就是儲存 local variables 的一個 dict;我會直接改成 locals

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm 倒好像也不用開,gloassary 裡面就只有全域區域,我直接更新術語表 wiki 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我會直接改成 locals

再看一下前後文發現他是指 local variables,就不改了

Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我成功跪著看完這個 PR 了 XD
真的好強

@mattwang44 mattwang44 requested a review from rockleona August 26, 2023 04:36
@rockleona
Copy link
Collaborator

rockleona commented Aug 26, 2023

LGTM! 手機版居然沒有approve
我晚點回去按一下

@mattwang44 mattwang44 merged commit dd4e9fb into python:3.12 Aug 26, 2023
@mattwang44 mattwang44 deleted the library/symtable branch August 26, 2023 15:52
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* feat: translate `library/symtable.po`

* fix(library/symtable): modify based on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants