Skip to content

README vs CONTRIBUTING #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srittau opened this issue May 12, 2021 · 1 comment · Fixed by #5429
Closed

README vs CONTRIBUTING #5422

srittau opened this issue May 12, 2021 · 1 comment · Fixed by #5429
Assignees
Labels
project: policy Organization of the typeshed project

Comments

@srittau
Copy link
Collaborator

srittau commented May 12, 2021

I just wanted to add information about the new supported METADATA fields, but I was a bit unsure on where to add them. We have a certain duplication between README and CONTRIBUTING. For example, the directory structure and the VERSIONS file is described in both files.

My suggestion: Move the sections "Directory structure" and "Running the tests" into CONTRIBUTING. Split "Directory structure" into "Stubs for the Python Standard Library" and "Stubs for Third-party Library" and partly merge the "Stub versioning" section into those sections. Then we can description VERSIONS in the stdlib section and METADATA in the third-party section. README will be kept fairly short, and everything to do with development is in CONTRIBUTING.

@srittau srittau added the project: policy Organization of the typeshed project label May 12, 2021
@JelleZijlstra
Copy link
Member

Sounds good, I'd also prefer to keep README short. Thanks for bringing this up! We could even add a third file (say SPECIFICATION.md) for the exhaustive detail on things like METADATA and VERSIONS, which isn't relevant to most contributors.

@srittau srittau self-assigned this May 12, 2021
hauntsaninja pushed a commit that referenced this issue May 12, 2021
This shuffles sections around between README.md and CONTRIBUTING.md. CONTRIBUTING now contains information pertaining to opening PRs, README all other information. I have also moved the list of maintainers to a separate file.

I have kept most information intact for now, with two main exceptions:

I removed duplicated information.
For brevity's sake, I trimmed some explanations from the section about version checks.
I have restructured the CONTRIBUTING file to follow the order of the introductory "contribution process at a glance" section. This now serves as a bit of a table of contents.

Closes: #5422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: policy Organization of the typeshed project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants