Deprecate pallets stubs #5424
Merged
Deprecate pallets stubs #5424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
May 12, 2021
| @@ -21,6 +21,7 @@ | |||
| {"stdlib/@python2/builtins.pyi", "stdlib/@python2/__builtin__.pyi"}, | |||
| {"stdlib/threading.pyi", "stdlib/_dummy_threading.pyi"}, | |||
| ] | |||
| metadata_keys = {"version", "python2", "python3", "requires", "extra_description", "obsolete_since"} | |||
There was a problem hiding this comment.
What's extra_description? It doesn't seem to be used anywhere else in this PR.
There was a problem hiding this comment.
It's unused at the moment, but I added it in typeshed-internal/stub_uploader#11 for future use.
There was a problem hiding this comment.
I plan to document METADATA.toml, but I need to resolve #5422 first.
Akuli
approved these changes
May 12, 2021
|
Now let's wait and see whether it work and the deprecation text gets added to the packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5423