Skip to content

Fix some errors with --disallow-any-generics #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 29, 2019
Merged

Fix some errors with --disallow-any-generics #3276

merged 13 commits into from
Sep 29, 2019

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 28, 2019 •
edited
Loading

Trying to help with #3267. I'm tackling all of stdlib/2and3 (and done with that now).

ilevkivskyi
ilevkivskyi approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

srittau
srittau approved these changes Sep 28, 2019
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srittau
Copy link
Collaborator

srittau commented Sep 29, 2019 •
edited
Loading

pytype is complaining about Union in shutil, so maybe try to move None out of the IgnoreFn union? Also cc @rchen152

Edit: Or just inline _IgnoreFn, since each alias is only used once anyway.

srittau added a commit to srittau/typeshed that referenced this pull request Sep 29, 2019
@srittau
Fix third_party errors with --disallow-any-generics
9d244e3 
Part of python#3267. Together with python#3276 this should fix all such problems.
@srittau srittau mentioned this pull request Sep 29, 2019
Merged
@gvanrossum gvanrossum merged commit b336182 into master Sep 29, 2019
@gvanrossum gvanrossum deleted the disallow-any-generics branch September 29, 2019 16:18
JelleZijlstra pushed a commit that referenced this pull request Sep 30, 2019
@srittau @JelleZijlstra
Fix third_party errors with --disallow-any-generics (#3278)
ed4b1de 
Part of #3267. Together with #3276 this should fix all such problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvanrossum @srittau @ilevkivskyi