Skip to content

Fix third_party errors with --disallow-any-generics #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 30, 2019
Merged

Fix third_party errors with --disallow-any-generics #3278

merged 10 commits into from
Sep 30, 2019

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 29, 2019

Part of #3267. Together with #3276 this should fix all such problems.

I mostly used Any annotations. These can often be improved with more specific types.

JelleZijlstra
JelleZijlstra requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this! I'm concerned that some of the changes to IO-like classes can lead to new false positives (comments inline).

@srittau
Copy link
Collaborator Author

srittau commented Sep 30, 2019

@JelleZijlstra I think I changed everything that needed to be changed.

@JelleZijlstra JelleZijlstra merged commit ed4b1de into python:master Sep 30, 2019
@srittau srittau deleted the disallow-any-generic branch September 30, 2019 11:56
@srittau srittau mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @JelleZijlstra