[stdlib][xml] Initial typestubs for xml.dom
#3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraftSpider
reviewed
Mar 16, 2020
CraftSpider
reviewed
Mar 16, 2020
srittau
requested changes
Mar 17, 2020
There was a problem hiding this comment.
Looks good, except for the NoneType -> None change pointed out by @CraftSpider. Regarding = ...: I don't think this was ever handled consistently, so for now it's probably best to just leave it out as redundant.
srittau
reviewed
Mar 26, 2020
|
Thanks for the review, @srittau and @CraftSpider! |
srittau
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add some typestubs for
xml. (as reported in #3787)I added 2 only to get the feel and then I'll add more after the review.