-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add empty stubs for xml.dom.* modules. #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not merging for now, since it conflicts with #3852. Also, empty files should instead have a top-level def __getattr__(name: str) -> Any: ... # incomplete |
Hah! Thanks for the pointer, I did miss that.
And funny how timing worked out with this. I'll retract this pull request once I'm in front of the computer.
…On Tue, Mar 17, 2020, at 13:36, Sebastian Rittau wrote:
Not merging for now, since it conflicts with #3852 <#3852>.
Also, empty files should instead have a top-level `__getattr__` definition per our CONTRIBUTING file:
def __getattr__(name: str) -> Any: ... # incomplete
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#3856 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASIUR3EA6B42BMMJ42JX3RH54FVANCNFSM4LNH47VQ>.
|
The PR is fine for minidom.pyi and pulldom.pyi, just __init__.pyi conflicts. |
Removed the It's not clear to me if the |
You still need to add the |
Yeah I was waiting to hear on whether I should need for the other one. Added now though. |
While this does not add any interface in the modules, it tells mypy that the modules _exist_, which is a starting point.
Is it good to go now? |
Looks good, still waiting for #3852, though, since that adds the |
I'll update the PR today! |
While this does not add any interface in the modules, it tells mypy that
the modules exist, which is a starting point.