Remove typing-extensions #1189
Merged
Remove typing-extensions #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
commented
May 19, 2022
| @@ -1,10 +1,8 @@ | |||
| [](https://gitter.im/python/typing?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | |||
|
|
|||
| Static Typing for Python | |||
| ======================== | |||
| # Static Typing for Python | |||
There was a problem hiding this comment.
Oops, I think this was some markdown autoformatter. Let me know if you'd like me to undo it.
There was a problem hiding this comment.
Good change, thanks unknown markdown formatter.
srittau
reviewed
May 19, 2022
| @@ -59,6 +29,3 @@ jobs: | |||
|
|
|||
| - name: Lint implementation | |||
| run: flake8 | |||
There was a problem hiding this comment.
Do we even need to run flake8? The only python code left is the typing-summary script in scripts.
There was a problem hiding this comment.
There is also docs/conf.py. I don't feel strongly, I can remove it if you feel we don't need linting for those.
There was a problem hiding this comment.
On the other hand, linting can't hurt, and who knows whether we add more scripts later. So I retract my comment.
srittau
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.