Skip to content

Remove typing-extensions #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ ignore =
E129,
# consistency with mypy
W504
exclude =
# tests have more relaxed formatting rules
# and its own specific config in .flake8-tests
typing_extensions/src/test_typing_extensions.py,
28 changes: 0 additions & 28 deletions .flake8-tests

This file was deleted.

33 changes: 0 additions & 33 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,36 +8,6 @@ permissions:
contents: read

jobs:
tests:
name: Run tests

strategy:
fail-fast: false
matrix:
# We try to test on the earliest available bugfix release of each
# Python version, because typing sometimes changed between bugfix releases.
# For available versions, see:
# https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
python-version: ["3.7", "3.7.1", "3.8", "3.8.0", "3.9", "3.9.0", "3.10", "3.10.0", "3.11-dev"]

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Test typing_extensions
continue-on-error: ${{ matrix.python-version == '3.11-dev' }}
run: |
# Be wary of running `pip install` here, since it becomes easy for us to
# accidentally pick up typing_extensions as installed by a dependency
cd typing_extensions/src
python -m unittest test_typing_extensions.py

linting:
name: Lint

Expand All @@ -59,6 +29,3 @@ jobs:

- name: Lint implementation
run: flake8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to run flake8? The only python code left is the typing-summary script in scripts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also docs/conf.py. I don't feel strongly, I can remove it if you feel we don't need linting for those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, linting can't hurt, and who knows whether we add more scripts later. So I retract my comment.


- name: Lint tests
run: flake8 --config=.flake8-tests typing_extensions/src/test_typing_extensions.py
71 changes: 0 additions & 71 deletions .github/workflows/package.yml

This file was deleted.

31 changes: 16 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
[![Chat at https://gitter.im/python/typing](https://badges.gitter.im/python/typing.svg)](https://gitter.im/python/typing?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)

Static Typing for Python
========================
# Static Typing for Python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I think this was some markdown autoformatter. Let me know if you'd like me to undo it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, thanks unknown markdown formatter.


Documentation and Support
-------------------------
## Documentation and Support

The documentation for Python's static typing can be found at
[typing.readthedocs.io](https://typing.readthedocs.io/). You can get
Expand All @@ -16,26 +14,29 @@ Improvements to the type system should be discussed on the
mailing list, although the [issues](https://github.com/python/typing/issues) in this
repository contain some historic discussions.

Repository Content
------------------
## Repository Content

This GitHub repository is used for several things:

- The `typing_extensions` module lives in the
[typing\_extensions](./typing_extensions) directory.

- The documentation at [typing.readthedocs.io](https://typing.readthedocs.io/)
is maintained in the [docs directory](./docs).

- A [discussion forum](https://github.com/python/typing/discussions) for typing-related user
help is hosted here.

Historically, this repository hosted a backport of the
[`typing` module](https://docs.python.org/3/library/typing.html) for older
Python versions. The last released version, supporting Python 2.7 and 3.4,
is [available at PyPI](https://pypi.org/project/typing/).
Historically, this repository also hosted:

- The `typing_extensions` package, which now lives in the
[typing_extensions](https://github.com/python/typing_extensions) repo.
It used to be in the `typing_extensions` directory.

- A backport of the
[`typing` module](https://docs.python.org/3/library/typing.html) for older
Python versions. It was removed after all Python versions that lack `typing`
in the standard library reached end of life. The last released version,
supporting Python 2.7 and 3.4,
is [available at PyPI](https://pypi.org/project/typing/).

Workflow
--------
## Workflow

See [CONTRIBUTING.md](/CONTRIBUTING.md) for more.
81 changes: 0 additions & 81 deletions typing_extensions/CHANGELOG.md

This file was deleted.

Loading