Skip to content

Building from source caused uint issue + suggested fix #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EnragedAntelope opened this issue Sep 26, 2024 · 3 comments
Closed

Building from source caused uint issue + suggested fix #951

EnragedAntelope opened this issue Sep 26, 2024 · 3 comments

Comments

@EnragedAntelope
Copy link
Contributor

Hi,
I was on torchao 0.1. When I used pip install --upgrade torchao, it kept me on 0.1 for some reason.

So I built from source, but wanted to let you know I encountered this error initially:

D:\ao\torchao\csrc\cuda\sparse_marlin\base.h(47): error: identifier "uint" is undefined

  using FragM = Vec<uint, 1>;
                    ^

I asked Claude to review, and it gave me a working solution:


1. Contact the package maintainers:
If this is a public package, you could report this issue to the maintainers of the torchao package. They might need to update their code to use unsigned int instead of uint, or properly include the necessary header that defines uint.

2. Modify the source code:
Open the file D:\ao\torchao\csrc\cuda\sparse_marlin\base.h
Find line 47 (or thereabouts)
Change uint to unsigned int

Just making you aware in case that change should be made for all.

Thank you!

@jcaip
Copy link
Contributor

jcaip commented Sep 26, 2024

cc @EnragedAntelope

Thanks for flagging, could you open a PR to make those changes? Feel free to tag me for review :)

@EnragedAntelope
Copy link
Contributor Author

Thank you. I tried and I would love to move it forward to you but I can't believe how much personal information it wants me to populate... have not encountered this before for a simple PR.

@jainapurva
Copy link
Contributor

Closing it as the issue doesn't exist anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants