Update base.h unit to unsigned int

[EnragedAntelope]

Changed uint to unsigned int to address error when building from source.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/962

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 92d89b8 with merge base d4b2f33 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Run Regression Tests / test (CPU Nightly, linux.4xlarge, --pre torch --index-url https://download.pytorch.org/whl/nightl... / linux-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @EnragedAntelope!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[jcaip]

Thanks for the fix! Should be fine to mere once tests pass

[msaroufim]

Hi @EnragedAntelope thank you for the contribution - some next steps

1. Can you merge or rebase to main to avoid the regression test failure
2. Can you please sign the CLA agreement otherwise we won't be able to merge this
3. Can you make it clearer what kind of device, operating system, gpu etc.. you're running such that you're getting from source installation errors?

[matthewdouglas]

@msaroufim See #951, likely Windows/MSVC. Very similar issue to the changes made in FP6 which used some non-standard types like 'u_int8_t`.

[EnragedAntelope]

Hi @EnragedAntelope thank you for the contribution - some next steps

1. Can you merge or rebase to main to avoid the regression test failure

2. Can you please sign the CLA agreement otherwise we won't be able to merge this

3. Can you make it clearer what kind of device, operating system, gpu etc.. you're running such that you're getting from source installation errors?

Hi,
Happy to help but sorry I won't sign that agreement, it requires actual name etc. I haven't been asked that for open source github before.

If there's a way to proceed without that I'm happy to try again with latest base.

For 3, I am running Windows 11 on a PC with 4090 GPU. Python 3.11.9.

[msaroufim]

@EnragedAntelope you can read more about CLAs here https://github.com/github/github-ospo/blob/main/policies/contributor-license-agreements.md but the intent is to say you give us the permission to use your contribution. It's quite common for projects managed by larger companies. Unfortunately I wouldn't even be able to copy paste your contribution since it's yours

[EnragedAntelope]

Thanks for the additional info. I signed the agreement and updated my fork. Should be good to go.