Revert "pin nightlies to deal with std::badalloc" #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e854ec.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1283
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit d722cf2 with merge base 26648c2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jcaip
added
the
topic: not user facing
jcaip
force-pushed
the
revert-1256-jcaip-patch-5
branch
from
b40c08c to
66e11fc
Compare
jerryzh168
reviewed
Nov 19, 2024
test/prototype/test_awq.py
Outdated
| @@ -70,7 +71,7 @@ def test_awq_loading(device, qdtype): | |||
|
|
|||
| model_save_path = "awq_model.pth" | |||
| torch.save(m, model_save_path) | |||
| loaded_model = torch.load(model_save_path) | |||
| loaded_model = torch.load(model_save_path, assign=True) | |||
There was a problem hiding this comment.
assign=True is an arg for model.load_state_dict(...) I think, see https://pytorch.org/ao/stable/serialization.html
|
@jcaip do you know what caused it and what fixed it? |
jerryzh168
approved these changes
Nov 20, 2024
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
* Revert "pin nightlies to deal with std::badalloc (pytorch#1256)" This reverts commit 0e854ec. * Update regression_test.yml * Update regression_test.yml * skip tests * update * work * fix * fix lint * Update test_awq.py * Update test_awq.py * Update regression_test.yml * Update regression_test.yml * Update regression_test.yml * Update regression_test.yml * Update regression_test.yml * Update test_awq.py * Update test_awq.py * Update test_awq.py * Update test_awq.py * Update test_awq.py * Update test_awq.py * Update test_awq.py * Update test_awq.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1256