migrate to linux_job_v2 and manylinux 2_28#1302
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1302
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6b5f811 with merge base d4ca98f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
HDCharles
added
the
topic: not user facing
HDCharles
changed the title
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
* Update float8_test.yml to use linux_job_v2 * Update nightly_smoke_test.yml * Update float8_test.yml no binutils * Update post_build_script.sh * Update post_build_script.sh * Update regression_test.yml * Update regression_test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to handle the migration of dev-infra from manylinux_2_26 to 2_28: pytorch/pytorch#123649
this required us update to linux_job_v2 for everything using nightly pytorch.
float8 tests: change to linux_job_v2 and remove binutils (they don't seem to be needed anymore)
nightly smoke tests: change to linux_job_v2
regression tests: only the nightlies need to use the new linux_job_v2, the rest needs to remain unchanged. We are currentlly pinning the pytorch version due to the bad_alloc tests but when that gets unpinned in #1283 the same changes for float8 test will need to be made to the nightly regression tests
these changes are working if CI is passing here
wheel builds: we update the manylinux version to 2_28, this was tested with https://github.com/pytorch/ao/actions/runs/11901019589 where all the cpu/cuda jobs pass, though we are still seeing failures with rocm jobs, that is a larger issue, unrelated to this PR, fixes for that are ongoing in pytorch/pytorch#140631