Skip to content

[ET-VK] Minor improvement to permute op. - #10117

Closed
trviv wants to merge 6 commits into
gh/trivedivivek/77/basefrom
gh/trivedivivek/77/head
Closed

trviv wants to merge 6 commits into
gh/trivedivivek/77/basefrom
gh/trivedivivek/77/head

Conversation

@trviv

@trviv trviv commented Apr 11, 2025 •

Copy link
Copy Markdown
Contributor

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Apr 11, 2025 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10117

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 35faf60 with merge base 047bbc7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

trviv added a commit that referenced this pull request Apr 11, 2025
This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

ghstack-source-id: 277629582
Pull Request resolved: #10117
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
trviv added a commit that referenced this pull request Apr 14, 2025
Pull Request resolved: #10117

This change reduces the complexity of boundary comparison in permute op to improve speed.
ghstack-source-id: 277869187
@exported-using-ghexport

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
trviv added a commit that referenced this pull request Apr 14, 2025
Pull Request resolved: #10117

This change reduces the complexity of boundary comparison in permute op to improve speed.
ghstack-source-id: 277933492
@exported-using-ghexport

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
trviv added a commit that referenced this pull request Apr 16, 2025
Pull Request resolved: #10117

This change reduces the complexity of boundary comparison in permute op to improve speed.
ghstack-source-id: 278374767
@exported-using-ghexport

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
trviv added a commit that referenced this pull request Apr 16, 2025
Pull Request resolved: #10117

This change reduces the complexity of boundary comparison in permute op to improve speed.
ghstack-source-id: 278469022
@exported-using-ghexport

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

This change reduces the complexity of boundary comparison in permute op to improve speed.

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)

[ghstack-poisoned]
trviv added a commit that referenced this pull request Apr 16, 2025
Pull Request resolved: #10117

This change reduces the complexity of boundary comparison in permute op to improve speed.
ghstack-source-id: 278469606
@exported-using-ghexport

Differential Revision: [D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D72866962

SS-JIA pushed a commit that referenced this pull request Apr 16, 2025
Contains commits squashed from #10117 PR stack.

Differential Revision: D72866962
Differential Revision: D72862490
Differential Revision: D72581293
Differential Revision: D72430290
SS-JIA added a commit that referenced this pull request Apr 16, 2025
Contains commits squashed from
#10117 PR stack.

Differential Revision:
[D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
Differential Revision:
[D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/)
Differential Revision:
[D72581293](https://our.internmc.facebook.com/intern/diff/D72581293/)
Differential Revision:
[D72430290](https://our.internmc.facebook.com/intern/diff/D72430290/)

@diff-train-skip-merge

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
keyprocedure pushed a commit to keyprocedure/executorch that referenced this pull request Apr 21, 2025
Contains commits squashed from
pytorch#10117 PR stack.

Differential Revision:
[D72866962](https://our.internmc.facebook.com/intern/diff/D72866962/)
Differential Revision:
[D72862490](https://our.internmc.facebook.com/intern/diff/D72862490/)
Differential Revision:
[D72581293](https://our.internmc.facebook.com/intern/diff/D72581293/)
Differential Revision:
[D72430290](https://our.internmc.facebook.com/intern/diff/D72430290/)

@diff-train-skip-merge

Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Aug 31, 2025
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

2 similar comments
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants