Update llama cmake for custom ops #10176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10176
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 55cf2ad with merge base 2ed44ce ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
added
the
release notes: build
lucylq
commented
Apr 14, 2025
| @@ -427,7 +427,7 @@ cmake -DPYTHON_EXECUTABLE=python \ | |||
| -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \ | |||
| -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \ | |||
| -DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \ | |||
| -DEXECUTORCH_BUILD_XNNPACK=ON \ | |||
| -DEXECUTORCH_BUILD_XNNPACK=OFF \ | |||
There was a problem hiding this comment.
update this to match the ci script.
metascroy
approved these changes
Apr 14, 2025
|
self-reminder to CP. |
|
@pytorchbot cherry-pick --onto release/0.6 -c fix |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/0.6 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 15, 2025
Fix #10166 target_link_options_shared_lib has different behavior for macos and other platforms; seems like whole-archive was causing issues. Test Plan `sh .ci/scripts/test_llama_torchao_lowbit.sh` https://github.com/pytorch/executorch/blob/main/examples/models/llama/README.md#running-with-low-bit-kernels (cherry picked from commit 5809428)
Cherry picking #10176The cherry pick PR is at #10201 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Fix pytorch#10166 target_link_options_shared_lib has different behavior for macos and other platforms; seems like whole-archive was causing issues. Test Plan `sh .ci/scripts/test_llama_torchao_lowbit.sh` https://github.com/pytorch/executorch/blob/main/examples/models/llama/README.md#running-with-low-bit-kernels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10166
target_link_options_shared_lib has different behavior for macos and other platforms; seems like whole-archive was causing issues.
Test Plan
sh .ci/scripts/test_llama_torchao_lowbit.shhttps://github.com/pytorch/executorch/blob/main/examples/models/llama/README.md#running-with-low-bit-kernels