Update llama cmake for custom ops #10201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #10166 target_link_options_shared_lib has different behavior for macos and other platforms; seems like whole-archive was causing issues. Test Plan `sh .ci/scripts/test_llama_torchao_lowbit.sh` https://github.com/pytorch/executorch/blob/main/examples/models/llama/README.md#running-with-low-bit-kernels (cherry picked from commit 5809428)
This was referenced Apr 15, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10201
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a97b808 with merge base 771588a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
metascroy
approved these changes
Apr 15, 2025
|
Waiting for CI before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10166
target_link_options_shared_lib has different behavior for macos and other platforms; seems like whole-archive was causing issues.
Test Plan
sh .ci/scripts/test_llama_torchao_lowbit.shhttps://github.com/pytorch/executorch/blob/main/examples/models/llama/README.md#running-with-low-bit-kernels