Skip to content

[ET-VK] Add coop shader for int8 linear #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Apr 18, 2025

Stack from ghstack (oldest at bottom):

Title says it all!

Changes

  • Apply co-operative shader for vector * matrix computations.

Differential Revision: D73279548

Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Apr 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10304

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit 97743ec with merge base 334af4a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA added a commit that referenced this pull request Apr 18, 2025
Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

ghstack-source-id: 279019175
Pull Request resolved: #10304
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73279548

Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Apr 23, 2025
Pull Request resolved: #10304

Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)
ghstack-source-id: 279777057
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73279548

Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Apr 23, 2025
Pull Request resolved: #10304

Title says it all!

## Changes

Add some utility functions to `ComputeGraph` to get the device name and look for substrings within the device name.

Apply co-operative shader for vector * matrix computations, except for Adreno 702 for which it performs worse as determined by experimentation.


ghstack-source-id: 279833964

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73279548

Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Apr 23, 2025
Pull Request resolved: #10304

Title says it all!

## Changes

Add some utility functions to `ComputeGraph` to get the device name and look for substrings within the device name.

Apply co-operative shader for vector * matrix computations, except for Adreno 702 for which it performs worse as determined by experimentation.


ghstack-source-id: 279878371

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73279548

@SS-JIA SS-JIA added the release notes: vulkan Changes to the Vulkan backend delegate label Apr 23, 2025
Title says it all!

## Changes

* Apply co-operative shader for vector * matrix computations.

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Apr 23, 2025
Pull Request resolved: #10304

Title says it all!

## Changes

Add some utility functions to `ComputeGraph` to get the device name and look for substrings within the device name.

Apply co-operative shader for vector * matrix computations, except for Adreno 702 for which it performs worse as determined by experimentation.


ghstack-source-id: 279884141

Differential Revision: [D73279548](https://our.internmc.facebook.com/intern/diff/D73279548/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73279548

@facebook-github-bot facebook-github-bot merged commit 8fd959a into gh/SS-JIA/215/base Apr 23, 2025
84 of 86 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/215/head branch April 23, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: vulkan Changes to the Vulkan backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants