[Android] Support 16bit output data as raw data byte[] #10412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In java, when the returned dtype is fp16 or bf16, instead of crash, use byte[] to represent these raw data, and let user parse the byte[]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10412
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 833d388 with merge base 98c2c53 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
topic: not user facing
module: benchmark
kirklandsign
added
the
module: android
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
changed the title
phaiting
reviewed
Apr 23, 2025
| @@ -674,6 +712,10 @@ private static Tensor nativeNewTensor( | |||
| tensor = new Tensor_uint8(data, shape); | |||
| } else if (DType.INT8.jniCode == dtype) { | |||
| tensor = new Tensor_int8(data, shape); | |||
| } else if (DType.HALF.jniCode == dtype) { | |||
| tensor = new Tensor_raw_data_16b(data, shape, DType.HALF); | |||
| } else if (DType.HALF.jniCode == dtype) { | |||
There was a problem hiding this comment.
This is same check as L715, should be DType.BFLOAT16.jniCode == dtype?
|
Per discussion, we use #10414 instead. Don't support it as output data type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In java, when the returned dtype is fp16 or bf16, instead of crash, use byte[] to represent these raw data, and let user parse the byte[]
We don't support fp16 or bf16 as input dtype. User can convert to fp32.
Resolved: #9881
Resolved: #10371
cc @cbilgin @guangy10 @huydhn @shoumikhin