Skip to content

[Android] Add Tensor_unsupoprted return type instead of crash #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2025

Conversation

kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Apr 23, 2025

Create a Tensor_unsupoprted object, which user can query its dtype and shape, but no other op supported. It will give an error saying user should re-export a model which Java supports.

Resolved: #10371

Copy link

pytorch-bot bot commented Apr 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10414

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f549064 with merge base dfd3dbe (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@kirklandsign kirklandsign marked this pull request as ready for review April 23, 2025 21:58
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign changed the title [Android] Add unknown Tensor type instead of crash [Android] Add Tensor_unsupoprted return type instead of crash Apr 23, 2025
@kirklandsign kirklandsign requested a review from tarun292 as a code owner April 24, 2025 00:01
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing comments

@facebook-github-bot facebook-github-bot merged commit d31ef13 into main Apr 24, 2025
84 of 86 checks passed
@facebook-github-bot facebook-github-bot deleted the java-unknown-type branch April 24, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add java layer fp16 support
5 participants