Restore CMake configure comment #2723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2723
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3178e80 with merge base 04d568d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
force-pushed
the
cmake-comment-fix
branch
3 times, most recently
from
82e3052 to
ee71e4c
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
cmake-comment-fix
branch
from
ee71e4c to
251a893
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
cmake-comment-fix
branch
from
251a893 to
3178e80
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mcr229
approved these changes
Mar 27, 2024
|
@GregoryComer merged this pull request in 9922c54. |
iseeyuan
pushed a commit
that referenced
this pull request
Mar 28, 2024
Summary: A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path). Test Plan: This is a comment-only change. I did configure and build on linux x86-64 to validate syntax. Reviewed By: mcr229 Differential Revision: D55445749 Pulled By: GregoryComer fbshipit-source-id: ff8cb601e71be4231f4e853b993bad9f54ea7144 [ghstack-poisoned]
iseeyuan
pushed a commit
that referenced
this pull request
Mar 28, 2024
Summary: A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path). Test Plan: This is a comment-only change. I did configure and build on linux x86-64 to validate syntax. Reviewed By: mcr229 Differential Revision: D55445749 Pulled By: GregoryComer fbshipit-source-id: ff8cb601e71be4231f4e853b993bad9f54ea7144 ghstack-source-id: f7130b55ae88264c10eec973ce4498e0bcedb6a4 Pull Request resolved: #2743
|
@pytorchbot cherry-pick --onto release/0.2 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Summary: A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path). Pull Request resolved: #2723 Test Plan: This is a comment-only change. I did configure and build on linux x86-64 to validate syntax. Reviewed By: mcr229 Differential Revision: D55445749 Pulled By: GregoryComer fbshipit-source-id: ff8cb601e71be4231f4e853b993bad9f54ea7144 (cherry picked from commit 9922c54)
Cherry picking #2723The cherry pick PR is at #2749 Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path).
Test Plan:
This is a comment-only change. I did configure and build on linux x86-64 to validate syntax.