Skip to content

Restore CMake configure comment #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path).

Test Plan:
This is a comment-only change. I did configure and build on linux x86-64 to validate syntax.

Summary:
A comment at the top of the top-level CMakeLists.txt file was removed previously as part of an update to automatically download buck. I removed more than was needed. This change restores the comment (minus the explicit buck path).

Pull Request resolved: #2723

Test Plan: This is a comment-only change. I did configure and build on linux x86-64 to validate syntax.

Reviewed By: mcr229

Differential Revision: D55445749

Pulled By: GregoryComer

fbshipit-source-id: ff8cb601e71be4231f4e853b993bad9f54ea7144
(cherry picked from commit 9922c54)
Copy link

pytorch-bot bot commented Mar 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2749

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5f4e2b6 with merge base a197412 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2024
@guangy10
Copy link
Contributor

guangy10 commented Apr 2, 2024

Merged via fast-forward

@guangy10 guangy10 closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants