use utils:{min,max}_override in {min,max}imum ops #3453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3453
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 7745534 with merge base b0c0e30 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 2, 2024
Summary: Pull Request resolved: pytorch#3453 Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 7, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
…ch#3459) Summary: Yet another smaller pair of ops. Reviewed By: manuelcandales Differential Revision: D56807402
…ytorch#3455) Summary: Continuing rollout of this technique. Reviewed By: manuelcandales Differential Revision: D56827786
…orch#3458) Summary: Yet another op that can benefit from compile-time type promotion. Reviewed By: manuelcandales Differential Revision: D56831293
…3456) Summary: Almost done with Tensor ops that can benefit from compile-time promotion! Reviewed By: manuelcandales Differential Revision: D56835200
Summary: IIUC, these ops need to support Half but don't. Noticed it as a difference from maximum. Reviewed By: manuelcandales Differential Revision: D56846242
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
added a commit
to swolchok/executorch
that referenced
this pull request
May 8, 2024
Summary: Noticed this inconsistency with clamp. Reviewed By: manuelcandales Differential Revision: D56846313
swolchok
force-pushed
the
export-D56846313
branch
2 times, most recently
from
74f4fc8 to
7745534
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D56846313 |
manuelcandales
approved these changes
May 9, 2024
|
This pull request has been merged in 38c30d6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Noticed this inconsistency with clamp.
Reviewed By: manuelcandales
Differential Revision: D56846313