Skip to content

[executorch] Rename FileDataLoader::From to ::from #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Sep 17, 2023

This is a commonly-used method that violates our style guide.

Differential Revision: [D49351745](https://our.internmc.facebook.com/intern/diff/D49351745/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e2dd0be.

@facebook-github-bot facebook-github-bot deleted the gh/dbort/4/head branch September 22, 2023 14:22
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Summary: All of the patches have been upstreamed to ExecuTorch in #3201

Test Plan: Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants