[ET-VK][int4] Wrap int4 linear calls with view_copy nodes to squeeze/unsqueeze inputs #8254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2025 16:56
…linear modules with biases Pull Request resolved: #8224 While LLaMa does not have biases, there are some models which will have biases in their linear modules. Add support in the source transform quantizer for biases. ghstack-source-id: 264952608 @exported-using-ghexport Differential Revision: [D69072087](https://our.internmc.facebook.com/intern/diff/D69072087/)
Pull Request resolved: #8225 If the partitioner is using channels-packed setting for activations, then the checks will throw. Remove the checks and conditionally re-pack the input/output tensors if they are not width-packed. ghstack-source-id: 264952605 @exported-using-ghexport Differential Revision: [D68813946](https://our.internmc.facebook.com/intern/diff/D68813946/)
…unsqueeze inputs Pull Request resolved: #8226 This is done automatically for full-precision linear/mm nodes in the graph at torch.export graph tracing time, but is not done for the int4 op. The new pass adds view_copy nodes, as there are subsequent passes which can fuse view_copy nodes if redundant, and convert view_copy nodes to squeeze/unsqueeze nodes. ghstack-source-id: 264952606 @exported-using-ghexport Differential Revision: [D69065866](https://our.internmc.facebook.com/intern/diff/D69065866/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8254
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 13da2d5 with merge base 7805229 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Feb 6, 2025
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #8226
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/nathanaelsee/3/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/nathanaelsee/3/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/nathanaelsee/2/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/nathanaelsee/3/orig
@diff-train-skip-merge