Skip to content

s/ifdef ET_LOG_ENABLED/if ET_LOG_ENABLED/ #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

swolchok
Copy link
Contributor

Looks like we define it to 0 rather than leaving it undefined to disable.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 12, 2025

Copy link

pytorch-bot bot commented Feb 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8403

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d5887fc with merge base ee7d388 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2025
swolchok added a commit that referenced this pull request Feb 12, 2025
Looks like we define it to 0 rather than leaving it undefined to disable.

ghstack-source-id: 71cf766
ghstack-comment-id: 2652545958
Pull Request resolved: #8403
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems reasonable but not sure how it fixes the CI..

@swolchok swolchok merged commit e32afa0 into main Feb 12, 2025
46 of 48 checks passed
@swolchok swolchok deleted the gh/swolchok/255/head branch February 12, 2025 16:01
@swolchok
Copy link
Contributor Author

how it fixes the CI.

when ET_LOG_DISABLED was defined to 0 (disabling logging), we were creating the strings to log (gated on #ifdef) but ET_LOG itself was disabled (gated on #if), so the strings were unused, triggering -Wunused-variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants