executorch-the-CMake-target should re-export executorch_core, shouldn't it?#8404
Merged
executorch-the-CMake-target should re-export executorch_core, shouldn't it?#8404
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8404
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit aa28e1c with merge base ee7d388 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
changed the title
cccclai
approved these changes
Feb 12, 2025
| # | ||
| add_library(executorch ${_executorch__srcs}) | ||
| target_link_libraries(executorch PRIVATE executorch_core) | ||
| target_link_libraries(executorch PUBLIC executorch_core) |
Contributor
There was a problem hiding this comment.
I'm not quite sure how this change fixes the error, but looks like CI is green
Contributor
Author
|
landing despite two job cancellations for timeout because it seems unlikely this would be related and it's an unbreak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix QNN build failures, and it doesn't make sense to me that every executorch (the CMake target) consumer should also have to explicitly link executorch_core