-
Notifications
You must be signed in to change notification settings - Fork 536
Split & remove extension_parallel #8983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
commented
Mar 10, 2025
ping reviewers @larryliu0820 @kirklandsign @lucylq @jackzhxng @iseeyuan @GregoryComer @kimishpatel |
This was referenced Mar 11, 2025
JacobSzwejbka
approved these changes
Mar 11, 2025
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
SS-JIA
pushed a commit
that referenced
this pull request
Mar 12, 2025
swolchok
added a commit
that referenced
this pull request
Mar 12, 2025
This reverts commit 05a160e. Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)"" This reverts commit 815eaff. Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)"" This reverts commit 10bb615. ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a ghstack-comment-id: 2718584686 Pull Request resolved: #9190
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
release notes: misc
Miscellaneous
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per plan in #8932, we want to be able to include thread_parallel.h to build
libraries that are capable of parallelization, but don't require it. So, we
move the header to ExecuTorch core and add a fallback implementation (with
tests!) of
parallel_for
that just does a regularfor
loop. Then, targetsthat link
extension_threadpool
will get parallelization automagically.This PR doesn't add any optionally-parallelized code; that will be in the next
PR.