Skip to content

Split & remove extension_parallel #8983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Mar 11, 2025
Merged

Split & remove extension_parallel #8983

merged 44 commits into from
Mar 11, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 6, 2025

As per plan in #8932, we want to be able to include thread_parallel.h to build
libraries that are capable of parallelization, but don't require it. So, we
move the header to ExecuTorch core and add a fallback implementation (with
tests!) of parallel_for that just does a regular for loop. Then, targets
that link extension_threadpool will get parallelization automagically.

This PR doesn't add any optionally-parallelized code; that will be in the next
PR.

swolchok added 23 commits March 4, 2025 11:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok requested a review from larryliu0820 as a code owner March 6, 2025 00:38
[ghstack-poisoned]
[ghstack-poisoned]
@JacobSzwejbka JacobSzwejbka removed their request for review March 10, 2025 18:20
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok removed the request for review from dbort March 11, 2025 01:50
@swolchok
Copy link
Contributor Author

[ghstack-poisoned]
@swolchok swolchok merged commit 2889483 into main Mar 11, 2025
49 of 50 checks passed
@swolchok swolchok deleted the gh/swolchok/315/head branch March 11, 2025 18:14
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 2889483.

ghstack-source-id: d44d019b3745260fe311b4eab570257050c782b7
ghstack-comment-id: 2718557885
Pull Request resolved: #9189
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
SS-JIA pushed a commit that referenced this pull request Mar 12, 2025
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in unittest-buck) (#9159)""

This reverts commit 10bb615.

ghstack-source-id: 2c4a363ff685022b388319f6565b74286fbf783a
ghstack-comment-id: 2718584686
Pull Request resolved: #9190
swolchok added a commit that referenced this pull request Mar 12, 2025
This reverts commit 05a160e.

Revert "Revert "Make serial parallel_for "polyfill" iterate backwards in
debug builds (#9044)""

This reverts commit 815eaff.

Revert "Revert "Unbreak optimized kernels buck build (and check it in
unittest-buck) (#9159)""

This reverts commit 10bb615.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants