[ET-VK] Fix debug build + print maximum storage buffer size with device limits #9016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce limits ## Context Two simple fixes/improvements. 1. Recently the interface to retrieve a `VkPipeline` from a pipeline cache was updated. Some code hidden behind debug compile flags was not updated. Updating the call site fixes building Vulkan with `etvk.debug = 1`. 2. Print the maximum storage buffer size when printing out the physical device limits. This is useful information to have. Differential Revision: [D70718388](https://our.internmc.facebook.com/intern/diff/D70718388/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 6, 2025
…ce limits ## Context Two simple fixes/improvements. 1. Recently the interface to retrieve a `VkPipeline` from a pipeline cache was updated. Some code hidden behind debug compile flags was not updated. Updating the call site fixes building Vulkan with `etvk.debug = 1`. 2. Print the maximum storage buffer size when printing out the physical device limits. This is useful information to have. Differential Revision: [D70718388](https://our.internmc.facebook.com/intern/diff/D70718388/) ghstack-source-id: 270150972 Pull Request resolved: #9016
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9016
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 85dc076 with merge base 2a5f8d4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70718388 |
jorgep31415
approved these changes
Mar 6, 2025
facebook-github-bot
merged commit 67438cf
into
gh/SS-JIA/191/base
52 of 55 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Mar 6, 2025
…ce limits ## Context Two simple fixes/improvements. 1. Recently the interface to retrieve a `VkPipeline` from a pipeline cache was updated. Some code hidden behind debug compile flags was not updated. Updating the call site fixes building Vulkan with `etvk.debug = 1`. 2. Print the maximum storage buffer size when printing out the physical device limits. This is useful information to have. Differential Revision: [D70718388](https://our.internmc.facebook.com/intern/diff/D70718388/) ghstack-source-id: 270150972 Pull Request resolved: #9016 Co-authored-by: Stephen Jia <[email protected]>
This was referenced Mar 17, 2025
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/) ghstack-source-id: 274200673 Pull Request resolved: #9648
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Mar 26, 2025
Pull Request resolved: #9648 ## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. ghstack-source-id: 274260087 @exported-using-ghexport Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/)
kirklandsign
pushed a commit
that referenced
this pull request
Mar 27, 2025
## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/) [ghstack-poisoned]
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
## Context As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in #9405. Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Two simple fixes/improvements.
VkPipelinefrom a pipeline cache was updated. Some code hidden behind debug compile flags was not updated. Updating the call site fixes building Vulkan withetvk.debug = 1.Differential Revision: D70718388