Skip to content

[ET-VK][ez] Fix printing shader IRs #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2025
Merged

[ET-VK][ez] Fix printing shader IRs #9648

merged 2 commits into from
Mar 26, 2025

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 26, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Context

As title; similar to #9016 since the interface for ComputePipeline descriptor was reverted in #9405.

Differential Revision: D71706868

@SS-JIA
[ET-VK][ez] Fix printing shader IRs
54a7a11 
## Context

As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in  #9405.

Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9648

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3dfe673 with merge base 7159650 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SS-JIA added a commit that referenced this pull request Mar 26, 2025
@SS-JIA
[ET-VK][ez] Fix printing shader IRs
ad09b0e 
## Context

As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in  #9405.

Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/)

ghstack-source-id: 274200673
Pull Request resolved: #9648
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71706868

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA
Update on "[ET-VK][ez] Fix printing shader IRs"
3dfe673 
## Context

As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in  #9405.

Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/)

[ghstack-poisoned]
SS-JIA added a commit that referenced this pull request Mar 26, 2025
@SS-JIA
[ET-VK][ez] Fix printing shader IRs
a313301 
Pull Request resolved: #9648

## Context

As title; similar to #9016 since the interface for `ComputePipeline` descriptor was reverted in  #9405.
ghstack-source-id: 274260087
@exported-using-ghexport

Differential Revision: [D71706868](https://our.internmc.facebook.com/intern/diff/D71706868/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71706868

@facebook-github-bot facebook-github-bot merged commit 691088a into gh/SS-JIA/201/base Mar 26, 2025
82 of 83 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/SS-JIA/201/head branch March 26, 2025 23:57
@pytorchbot pytorchbot mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipjustin yipjustin yipjustin approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SS-JIA @facebook-github-bot @yipjustin