Skip to content

Query most of //kernels in unittest buck #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 10, 2025
Merged

Query most of //kernels in unittest buck #9040

merged 29 commits into from
Mar 10, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 7, 2025 •
edited
Loading

Buck builds don't work yet, but let's check what we can.

Differential Revision: D70791339

@swolchok
Update
65aeed2 
[ghstack-poisoned]
@swolchok
Update
545a05b 
[ghstack-poisoned]
@swolchok
Update
d85e255 
[ghstack-poisoned]
@swolchok
Update
5124a63 
[ghstack-poisoned]
@swolchok
Update
146cfa6 
[ghstack-poisoned]
@swolchok
Update
dce054b 
[ghstack-poisoned]
@swolchok
Update
40bcf6f 
[ghstack-poisoned]
@swolchok
Update
cece5bc 
[ghstack-poisoned]
@swolchok
Update
3c40a8b 
[ghstack-poisoned]
@swolchok
Update
96b69c8 
[ghstack-poisoned]
@swolchok
Update
699a8f4 
[ghstack-poisoned]
@swolchok
Update
9c10640 
[ghstack-poisoned]
@swolchok
Update
8d3a9ba 
[ghstack-poisoned]
@swolchok
Update
e90e779 
[ghstack-poisoned]
@swolchok
Update
7560880 
[ghstack-poisoned]
@swolchok
Update
e0cb34f 
[ghstack-poisoned]
@swolchok
Update
ea92179 
[ghstack-poisoned]
@swolchok
Update
891fb8e 
[ghstack-poisoned]
@swolchok
Update
05528b4 
[ghstack-poisoned]
@swolchok
Update
26a2025 
[ghstack-poisoned]
@swolchok
Update
d8cd4f2 
[ghstack-poisoned]
@swolchok
Update
b099a8a 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9040

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs

As of commit c28f087 with merge base e6d44fa (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Mar 7, 2025
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@swolchok swolchok mentioned this pull request Mar 7, 2025
Merged
swolchok added a commit that referenced this pull request Mar 7, 2025
@swolchok
Query most of //kernels in unittest buck
ee6d601 
Buck builds don't work yet, but let's check what we can.

ghstack-source-id: 1e97327f7fc50e4af4bfa019f469379294276521
ghstack-comment-id: 2706906567
Pull Request resolved: #9040
swolchok added 2 commits March 7, 2025 08:40
@swolchok
Update
eabf3ff 
[ghstack-poisoned]
@swolchok
Update
93e12a2 
[ghstack-poisoned]
@swolchok
Update
c532461 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 7, 2025
@swolchok
Query most of //kernels in unittest buck
7d07062 
Buck builds don't work yet, but let's check what we can.

ghstack-source-id: 4f4951ca6d49b6e89aeda8396942e2c8d7f9f3ff
ghstack-comment-id: 2706906567
Pull Request resolved: #9040
This was referenced Mar 7, 2025
Merged
Merged
swolchok added 2 commits March 7, 2025 09:27
@swolchok
Update
0a3a58b 
[ghstack-poisoned]
@swolchok
Update
3c30f09 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 7, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

swolchok added 2 commits March 7, 2025 17:34
@swolchok
Update
a088f9f 
[ghstack-poisoned]
@swolchok
Update
c28f087 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 8, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
Base automatically changed from gh/swolchok/291/head to main March 10, 2025 16:32
iseeyuan
iseeyuan approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me to have more deps on unittests. The only tests that don't have those deps may be the binary size test for runtime.

@swolchok swolchok merged commit 46d0580 into main Mar 10, 2025
86 of 92 checks passed
@swolchok swolchok deleted the gh/swolchok/320/head branch March 10, 2025 22:30
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iseeyuan iseeyuan iseeyuan approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @iseeyuan @facebook-github-bot