Skip to content

Test most of //runtime in unittest-buck #8713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 10, 2025
Merged

Test most of //runtime in unittest-buck #8713

merged 25 commits into from
Mar 10, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 26, 2025

Ended up having to skip //runtime/test/..., which means some previous PRs aren't strictly necessary, so don't feel obliged to accept them all.

Differential Revision: D70791341

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8713

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit a088f9f with merge base e6d44fa (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
swolchok added a commit that referenced this pull request Feb 26, 2025
Ended up having to skip //runtime/test/..., which means some previous PRs aren't strictly necessary, so don't feel obliged to accept them all.

ghstack-source-id: ff9fb1c9ea8f6652db98c81981341a005be86515
ghstack-comment-id: 2683602764
Pull Request resolved: #8713
@swolchok swolchok changed the title Test most of //runtime in unittest buck Test most of //runtime in unittest-buck Feb 26, 2025
@swolchok
Copy link
Contributor Author

ping reviewers @dbort @JacobSzwejbka @lucylq

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 28, 2025
Ended up having to skip //runtime/test/..., which means some previous PRs aren't strictly necessary, so don't feel obliged to accept them all.

ghstack-source-id: 1d0cf52bedcc72bda9a8121c81a741358fd350fb
ghstack-comment-id: 2683602764
Pull Request resolved: #8713
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 28, 2025
swolchok added 2 commits March 4, 2025 10:17
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added 2 commits March 5, 2025 11:26
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
Ended up having to skip //runtime/test/..., which means some previous PRs aren't strictly necessary, so don't feel obliged to accept them all.

ghstack-source-id: 184a255036c398dd05e5f8b80b55c0e56586a304
ghstack-comment-id: 2683602764
Pull Request resolved: #8713
swolchok added 2 commits March 7, 2025 08:09
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 7, 2025
Ended up having to skip //runtime/test/..., which means some previous PRs aren't strictly necessary, so don't feel obliged to accept them all.

ghstack-source-id: 5b1c79b7fbdec1852defe94652176f701a666682
ghstack-comment-id: 2683602764
Pull Request resolved: #8713
swolchok added 2 commits March 7, 2025 08:40
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok changed the base branch from gh/swolchok/290/head to main March 7, 2025 17:27
@swolchok
Copy link
Contributor Author

swolchok commented Mar 7, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 8, 2025

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok swolchok merged commit 1d34caf into main Mar 10, 2025
86 of 91 checks passed
@swolchok swolchok deleted the gh/swolchok/291/head branch March 10, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants