Skip to content

test buck2 query for much more of the repo #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 28, 2025
Merged

Conversation

swolchok
Copy link
Contributor

Had to fix a couple .buckconfig issues post-shim_et to enable this.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8660

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 3c40a8b with merge base 2be4e94 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
swolchok added a commit that referenced this pull request Feb 25, 2025
Had to fix a couple .buckconfig issues post-shim_et to enable this.

ghstack-source-id: d3e7ed4647530aa45af9c857629693f8eede5e5b
ghstack-comment-id: 2680126405
Pull Request resolved: #8660
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Feb 25, 2025
@swolchok swolchok changed the title defend buck2 query for much more of the repo test buck2 query for much more of the repo Feb 25, 2025
[ghstack-poisoned]
@swolchok swolchok changed the base branch from main to gh/swolchok/286/head February 25, 2025 02:14
swolchok added a commit that referenced this pull request Feb 25, 2025
Had to fix a couple .buckconfig issues post-shim_et to enable this.

ghstack-source-id: 0417bd894b3e84e22b81f944dc240670850ac481
ghstack-comment-id: 2680126405
Pull Request resolved: #8660
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Had to fix a couple .buckconfig issues post-shim_et to enable this.

ghstack-source-id: a19745e7d2bc5670364fea73c808c287bb495717
ghstack-comment-id: 2680126405
Pull Request resolved: #8660
Base automatically changed from gh/swolchok/286/head to main February 25, 2025 16:48
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Had to fix a couple .buckconfig issues post-shim_et to enable this.

ghstack-source-id: 8e9811859345b599db629c2e0f1ce00253e0b656
ghstack-comment-id: 2680126405
Pull Request resolved: #8660
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 25, 2025
Had to fix a couple .buckconfig issues post-shim_et to enable this.

ghstack-source-id: 30f82ca6b33e652bba9261b736b0c3ec453a4567
ghstack-comment-id: 2680126405
Pull Request resolved: #8660
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

ping reviewers @larryliu0820 @mergennachin

Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dogscience

@swolchok swolchok merged commit dfe11f0 into main Feb 28, 2025
83 of 84 checks passed
@swolchok swolchok deleted the gh/swolchok/284/head branch February 28, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants