fix headers attribute of cxx_test in OSS #8662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8662
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 26 PendingAs of commit 146cfa6 with merge base 6cb5c1a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
requested review from
mergennachin,
larryliu0820,
dbort and
GregoryComer
and removed request for
mergennachin
swolchok
added
the
release notes: build
swolchok
requested review from
kirklandsign,
cccclai,
JacobSzwejbka,
lucylq,
manuelcandales,
shoumikhin,
kimishpatel,
tarun292 and
Gasoonjia
as code owners
mergennachin
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to make header paths work for cxx_test headers.
Test Plan: buck2 build //runtime/kernel/test:operator_registry_test