Skip to content

Don't define aten-mode targets in OSS #8661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Don't define aten-mode targets in OSS #8661

merged 1 commit into from
Feb 25, 2025

Conversation

swolchok
Copy link
Contributor

Define get_aten_mode_options in runtime_wrapper and use it.

Test Plan: buck2 build //runtime/... has many fewer errors now (aten-mode targets were failing)

@swolchok
Update
545a05b 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8661

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 545a05b with merge base 745be4e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Feb 25, 2025
@swolchok
Don't define aten-mode targets in OSS
939b723 
Define get_aten_mode_options in runtime_wrapper and use it.

Test Plan: buck2 build //runtime/... has many fewer errors now (aten-mode targets were failing)

ghstack-source-id: 3960223
ghstack-comment-id: 2680170786
Pull Request resolved: #8661
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
@facebook-github-bot
Copy link
Contributor

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820
larryliu0820 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

This was referenced Feb 25, 2025
Merged
Merged
@swolchok swolchok merged commit f1a7d60 into main Feb 25, 2025
55 of 57 checks passed
@swolchok swolchok deleted the gh/swolchok/285/head branch February 25, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@dbort dbort Awaiting requested review from dbort

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@tarun292 tarun292 Awaiting requested review from tarun292 tarun292 is a code owner

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @facebook-github-bot @larryliu0820