Skip to content

mkdir when destination directory doesn't exist #9055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Mar 7, 2025

Stack from ghstack (oldest at bottom):

Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

cc @lucylq

Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9055

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 738c9f0 with merge base 6099020 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

larryliu0820 added a commit that referenced this pull request Mar 7, 2025
Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

ghstack-source-id: 2467d1230b90a8c8e4b676b3915675471517f4fd
Pull Request resolved: #9055
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@larryliu0820 larryliu0820 added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels Mar 7, 2025
Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

cc lucylq

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Mar 7, 2025
Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

ghstack-source-id: 745e02d5e147f67927a86ccb25a4330e2aceeccd
Pull Request resolved: #9055
@larryliu0820 larryliu0820 merged commit 9a089d4 into gh/larryliu0820/63/base Mar 7, 2025
49 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/63/head branch March 7, 2025 21:00
larryliu0820 added a commit that referenced this pull request Mar 7, 2025
Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

ghstack-source-id: 745e02d5e147f67927a86ccb25a4330e2aceeccd
Pull Request resolved: #9055

Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants