Skip to content

mkdir when destination directory doesn't exist #9060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

mkdir when destination directory doesn't exist #9060

merged 1 commit into from
Mar 7, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9055 by @larryliu0820
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/63/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/63/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/63/orig
@diff-train-skip-merge

@larryliu0820
mkdir when destination directory doesn't exist
98b2ab4 
Fixes #8980

Make sure we mkdir if destination directory doesn't exist. I have no
idea why it doesn't work before

ghstack-source-id: 745e02d5e147f67927a86ccb25a4330e2aceeccd
Pull Request resolved: #9055
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9060

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 98b2ab4 with merge base 6099020 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@larryliu0820 larryliu0820 added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 7, 2025
@larryliu0820 larryliu0820 merged commit 169e6ae into main Mar 7, 2025
50 of 52 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/63/orig branch March 7, 2025 21:57
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @larryliu0820 @facebook-github-bot