Turn on EXECUTORCH_BUILD_PYBIND when implicitly wanted #9611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9611
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 149e5bc with merge base 610f398 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
force-pushed
the
jathu/no-redefine-pybind
branch
from
c70d3fe to
2327924
Compare
jathu
added
ciflow/trunk
ciflow/binaries/all
jathu
force-pushed
the
jathu/no-redefine-pybind
branch
from
2327924 to
d5ee210
Compare
jathu
force-pushed
the
jathu/no-redefine-pybind
branch
from
d5ee210 to
149e5bc
Compare
jathu
added
module: build/install
larryliu0820
approved these changes
Mar 26, 2025
jathu
added a commit
that referenced
this pull request
Mar 31, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
### Summary We want `EXECUTORCH_BUILD_PYBIND` enabled if the user wants to build the bindings — so let's just do it. Unless of course, they explicitly choose not to by defining the arg themselves. ### Test plan CI cc @larryliu0820 @lucylq
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want
EXECUTORCH_BUILD_PYBINDenabled if the user wants to build the bindings — so let's just do it. Unless of course, they explicitly choose not to by defining the arg themselves.Test plan
CI
cc @larryliu0820 @lucylq