Skip to content

Fix flake8 issues introduced as a result of #1546 #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2022
Merged

Fix flake8 issues introduced as a result of #1546 #1617

merged 3 commits into from
Feb 17, 2022

Conversation

abhinavarora
Copy link
Contributor

No description provided.

@abhinavarora abhinavarora requested review from parmeet and Nayef211 and removed request for parmeet February 17, 2022 17:47
parmeet
parmeet approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #1617 (38cbfd2) into main (c31a400) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   85.28%   85.25%   -0.03%     
==========================================
  Files          58       58              
  Lines        2488     2483       -5     
==========================================
- Hits         2122     2117       -5     
  Misses        366      366
Impacted Files Coverage Δ
torchtext/datasets/ag_news.py 95.23% <ø> (-0.22%) ⬇️
torchtext/datasets/conll2000chunking.py 95.83% <ø> (-0.17%) ⬇️
torchtext/datasets/squad1.py 95.00% <ø> (-0.24%) ⬇️
torchtext/datasets/squad2.py 95.00% <ø> (-0.24%) ⬇️
torchtext/data/datasets_utils.py 74.66% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31a400...38cbfd2. Read the comment docs.

@abhinavarora abhinavarora merged commit ebabe82 into pytorch:main Feb 17, 2022
@abhinavarora abhinavarora deleted the fix_flake branch February 17, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmeet parmeet parmeet approved these changes

@Nayef211 Nayef211 Awaiting requested review from Nayef211

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhinavarora @parmeet @facebook-github-bot