Skip to content

Fix flake8 issues introduced as a result of #1546 #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Fix flake8 issues introduced as a result of #1546 #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4361e01
Remove unnecessary select option in flake8 configs
abhinavarora Feb 17, 2022
fc0c345
Flake8 select all lint options that we care about
abhinavarora Feb 17, 2022
38cbfd2
Fix Flake8 errors
abhinavarora Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
[flake8]
ignore = E401,E402,E501,E722,W503,W504,F821,B006,B007,B008,B009
select = D417 # Missing argument descriptions in the docstring
ignore =
E401,E402,E501,E722,W503,W504,F821,B006,B007,B008,B009,
E203 # https://github.com/PyCQA/pycodestyle/issues/373
select =
B,C,E,F,P,T4,W,B9,
D417 # Missing argument descriptions in the docstring
max-line-length = 120
exclude = docs/source,third_party
7 changes: 1 addition & 6 deletions torchtext/data/datasets_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@
import torch
from torch.utils.data import functional_datapipe, IterDataPipe
from torch.utils.data.datapipes.utils.common import StreamWrapper
from torchtext.utils import download_from_url, extract_archive, unicode_csv_reader, validate_file
from torchtext.utils import (
validate_file,
download_from_url,
extract_archive,
)
from torchtext.utils import download_from_url, extract_archive, validate_file

try:
import defusedxml.ElementTree as ET
Expand Down
2 changes: 0 additions & 2 deletions torchtext/datasets/ag_news.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
from torchdata.datapipes.iter import FileOpener, HttpReader, IterableWrapper


from torchtext.data.datasets_utils import _add_docstring_header, _create_dataset_directory, _wrap_split_argument

URL = {
"train": "https://raw.githubusercontent.com/mhjabreel/CharCnn_Keras/master/data/ag_news_csv/train.csv",
"test": "https://raw.githubusercontent.com/mhjabreel/CharCnn_Keras/master/data/ag_news_csv/test.csv",
Expand Down
2 changes: 0 additions & 2 deletions torchtext/datasets/conll2000chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
from torchdata.datapipes.iter import FileOpener, HttpReader, IterableWrapper


from torchtext.data.datasets_utils import _add_docstring_header, _create_dataset_directory, _wrap_split_argument

URL = {
"train": "https://www.clips.uantwerpen.be/conll2000/chunking/train.txt.gz",
"test": "https://www.clips.uantwerpen.be/conll2000/chunking/test.txt.gz",
Expand Down
2 changes: 0 additions & 2 deletions torchtext/datasets/squad1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
from torchdata.datapipes.iter import FileOpener, HttpReader, IterableWrapper


from torchtext.data.datasets_utils import _add_docstring_header, _create_dataset_directory, _wrap_split_argument

URL = {
"train": "https://rajpurkar.github.io/SQuAD-explorer/dataset/train-v1.1.json",
"dev": "https://rajpurkar.github.io/SQuAD-explorer/dataset/dev-v1.1.json",
Expand Down
2 changes: 0 additions & 2 deletions torchtext/datasets/squad2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
from torchdata.datapipes.iter import FileOpener, HttpReader, IterableWrapper


from torchtext.data.datasets_utils import _add_docstring_header, _create_dataset_directory, _wrap_split_argument

URL = {
"train": "https://rajpurkar.github.io/SQuAD-explorer/dataset/train-v2.0.json",
"dev": "https://rajpurkar.github.io/SQuAD-explorer/dataset/dev-v2.0.json",
Expand Down