fix missed mask arg in torchtext transformer

[erichan1]

Add src_key_padding_mask arg to fix numerical difference if there is padding.

[parmeet]

Thanks @erichan1 for providing the quick fix to this issue. Unfortunately, i am seeing failure with scripting model. Could you please take a look?

test/integration_tests/test_models.py::TestRobertaEncoders::test_roberta_base_model_0_jit Fatal Python error: Aborted

[erichan1]

Thanks @erichan1 for providing the quick fix to this issue. Unfortunately, i am seeing failure with scripting model. Could you please take a look?

test/integration_tests/test_models.py::TestRobertaEncoders::test_roberta_base_model_0_jit Fatal Python error: Aborted

This fix relies on this fix pytorch/pytorch#78832 to work. With these together, the integration tests pass on a local run.

[parmeet]

This fix relies on this fix pytorch/pytorch#78832 to work. With these together, the integration tests pass on a local run.

Sounds great! Let's just wait for the pytorch nightlies to reflect these changes and we can land/cherry-pick this PR in the release branch.

[parmeet]

@Nayef211 This is one of the candidates for cherry-picking..

[Nayef211]

@Nayef211 This is one of the candidates for cherry-picking..

Sounds good thanks for calling it out!

[parmeet]

Looks like the model specific tests are passing. The failures in this PR are related to old issues that are fixed in main branch. I will go ahead and merge it. cc: @Nayef211

[parmeet]

LGTM! Thanks @erichan1 for providing with the fix :)