Skip to content

[cherry-pick] Fix missed mask arg in torchtext transformer (#1758) #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2022
Merged

[cherry-pick] Fix missed mask arg in torchtext transformer (#1758) #1768

merged 1 commit into from
Jun 7, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Jun 6, 2022

No description provided.

@Nayef211 Nayef211 changed the base branch from main to release/0.13 June 6, 2022 23:02
@Nayef211 Nayef211 requested review from parmeet and vcm2114 June 6, 2022 23:03
@Nayef211 Nayef211 marked this pull request as ready for review June 6, 2022 23:04
@codecov
Copy link

codecov bot commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #1768 (9ad8326) into release/0.13 (cd51a7d) will not change coverage.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##           release/0.13    #1768   +/-   ##
=============================================
  Coverage         89.89%   89.89%           
=============================================
  Files                55       55           
  Lines              2602     2602           
=============================================
  Hits               2339     2339           
  Misses              263      263
Impacted Files Coverage Δ
torchtext/models/roberta/modules.py 64.58% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd51a7d...9ad8326. Read the comment docs.

parmeet
parmeet approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 853dd5d into pytorch:release/0.13 Jun 7, 2022
@Nayef211 Nayef211 mentioned this pull request Jun 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmeet parmeet parmeet approved these changes

@vcm2114 vcm2114 Awaiting requested review from vcm2114

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nayef211 @parmeet @facebook-github-bot @erichan1