Add typing to detection model (rpn).

[khushi-411]

Hi,
I'm excited to contribute to PyTorch. It is my first PR towards PyTorch's vision repo.

Related PR's

It is the follow-up for the #2025 PR.

I also referred to various other PR's like #4369, #4236 and a few more.

Aim of PR

The PR aims to add type annotations in the following parts:

• Region Proposal Networks (torchvision/models/detection/rpn.py)
• Region of Interest heads (torchvision/models/detection/roi_heads.py)
• Generalized R-CNN (torchvision/models/detection/generalized_rcnn.py)

I'm looking forward to your viewpoints. Thanks!

[facebook-github-bot]

Hi @khushi-411!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[oke-aditya]

Hi @khushi-411 Can you have a look at #4220 ?
I'm about to split that PR into multiple PRs

Edit:

It's quite exciting to get first PR merged. So let me know what you think?
We can sync on this and open PRs accordingly.

[khushi-411]

Hi @oke-aditya,
Thanks a lot for sharing. I wasn't aware of that discussion.

I took a brief view of the PR you shared. That's a great idea to split the PR into smaller ones. It will be easier for the ones who are reviewing.
By the way, I just thought, if you are already working on that PR. Shall I pick another one and close this PR?
Though It will be great if we can work together.

I'm looking forward to your viewpoints. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[oke-aditya]

We can work together. I will split up the PR today and also grant you access to my forked copy. You can then switch the branches on my fork and push as well.

There are many files to work, it will be good to collaborate.

[khushi-411]

Cool, thanks!

[datumbox]

@khushi-411 Welcome! I see you are working with @oke-aditya on #4582. Great coordination effort, looking forward to the PRs.

[khushi-411]

Thanks, @datumbox! Glad to start!