Skip to content

Add typing annotations to models/detection #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 of 14 tasks
oke-aditya opened this issue Oct 10, 2021 · 3 comments
Open
5 of 14 tasks

Add typing annotations to models/detection #4582

oke-aditya opened this issue Oct 10, 2021 · 3 comments

Comments

@oke-aditya
Copy link
Contributor

oke-aditya commented Oct 10, 2021

🚀 The feature

This is an issue to track down all the files in detection module and work up the chain.

To type the models, all the above files would need to have annotations.

Motivation, pitch

@khushi-411 and I will sync and work on these files.

Solving This issue also helps #2025

As first step I'm closing #4220 and splitting it up into multiple PRs preferably one file each.

Hopefully we should complete this soon.

Alternatives

Note that there are cases where we have make JIT happy over mypy.

Most of these cases occur as JIT does not Support Tuple fully. In most cases we should prefer List.

Additional context

cc @datumbox @pmeier @NicolasHug

@datumbox
Copy link
Contributor

Sounds goo.d I think SSD and SSDlite are mostly done. We are missing a couple of return types but parameters should be in place.

@khushi-411
Copy link
Contributor

Let's start with other files too! @oke-aditya, have you started with any of them?

I'm moving ahead with backbone_utils.py. Please ping me if you have taken it up.

@oke-aditya
Copy link
Contributor Author

Go ahead 😄 Just remember that after #4583 is merged you would need to remove that file from mypy.ini configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants