Add typing annotations to detection/backbone_utils #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oke-aditya
commented
Oct 12, 2021
oke-aditya
commented
Oct 12, 2021
14 tasks
|
FYI, there is another file in prototypes that should be types along with this: |
|
@khushi-411 CI failure seem to be related. Do you want to give a try and fix stuff? |
datumbox
reviewed
Oct 18, 2021
oke-aditya
changed the title
oke-aditya
commented
Oct 18, 2021
|
This should be good to merge once CI is green 😃 |
datumbox
approved these changes
Oct 18, 2021
oke-aditya
commented
Oct 18, 2021
Address nits Co-authored-by: Vasilis Vryniotis <[email protected]>
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 25, 2021
Summary: * Start adding types * add typing * Type prototype models * fix optional type bug * transient import * Fix weights type * fix import * Apply suggestions from code review Address nits Reviewed By: datumbox Differential Revision: D31898218 fbshipit-source-id: e52ab136755ed0d0cc975a2ec914bd285f3d0674 Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Khushi Agrawal <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Start adding types * add typing * Type prototype models * fix optional type bug * transient import * Fix weights type * fix import * Apply suggestions from code review Address nits Co-authored-by: Vasilis Vryniotis <[email protected]> Co-authored-by: Khushi Agrawal <[email protected]> Co-authored-by: Vasilis Vryniotis <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4582
A headstart for @khushi-411 😃
Initially I was bit hesitant to start, but soon felt that this file isn't very simple for new contributor.
I have just added a couple of types. I felt this would help you.
cc @datumbox